Compare a given version number in the form major.minor.build.patch and see if one is less than the other Announcing the arrival of Valued Associate #679: Cesar Manara Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Displaying the number of elements larger than the average of an arrayFirst prime number larger than given integerFind smallest prime number greater than given nPrinting twin primes less than a given natural number nFind how many numbers in an array are less than each number in the arraySimple pool of threads which calculate the sum of a given number from the main processCalculate the number of palindrome numbers in the given rangesA program to find out the number of odd and even Fibonacci numbers between given rangeFind the smallest number in the first array that is not in the second oneFind the sum of the digits of a given number

Do I really need recursive chmod to restrict access to a folder?

How do I stop a creek from eroding my steep embankment?

Identify plant with long narrow paired leaves and reddish stems

Can an alien society believe that their star system is the universe?

When a candle burns, why does the top of wick glow if bottom of flame is hottest?

Check which numbers satisfy the condition [A*B*C = A! + B! + C!]

Why did the IBM 650 use bi-quinary?

Seeking colloquialism for “just because”

How to answer "Have you ever been terminated?"

Extract all GPU name, model and GPU ram

What does this icon in iOS Stardew Valley mean?

Why are Kinder Surprise Eggs illegal in the USA?

How to react to hostile behavior from a senior developer?

The logistics of corpse disposal

How widely used is the term Treppenwitz? Is it something that most Germans know?

Generate an RGB colour grid

Ring Automorphisms that fix 1.

Single word antonym of "flightless"

Error "illegal generic type for instanceof" when using local classes

What exactly is a "Meth" in Altered Carbon?

Why is "Consequences inflicted." not a sentence?

Is the Standard Deduction better than Itemized when both are the same amount?

Why didn't this character "real die" when they blew their stack out in Altered Carbon?

What causes the vertical darker bands in my photo?



Compare a given version number in the form major.minor.build.patch and see if one is less than the other



Announcing the arrival of Valued Associate #679: Cesar Manara
Planned maintenance scheduled April 17/18, 2019 at 00:00UTC (8:00pm US/Eastern)Displaying the number of elements larger than the average of an arrayFirst prime number larger than given integerFind smallest prime number greater than given nPrinting twin primes less than a given natural number nFind how many numbers in an array are less than each number in the arraySimple pool of threads which calculate the sum of a given number from the main processCalculate the number of palindrome numbers in the given rangesA program to find out the number of odd and even Fibonacci numbers between given rangeFind the smallest number in the first array that is not in the second oneFind the sum of the digits of a given number



.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty margin-bottom:0;








4












$begingroup$


#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <stdbool.h>

typedef int STATUS;
#define ERROR -1
#define OKAY 0

struct version

unsigned char major;
unsigned char minor;
unsigned char build;
unsigned char patch;
;
STATUS is_less_than(struct version * original, struct version *compared, bool *result)



Is there a cleaner way to do this?










share|improve this question









$endgroup$


















    4












    $begingroup$


    #include <stdio.h>
    #include <stdlib.h>
    #include <string.h>
    #include <stdbool.h>

    typedef int STATUS;
    #define ERROR -1
    #define OKAY 0

    struct version

    unsigned char major;
    unsigned char minor;
    unsigned char build;
    unsigned char patch;
    ;
    STATUS is_less_than(struct version * original, struct version *compared, bool *result)



    Is there a cleaner way to do this?










    share|improve this question









    $endgroup$














      4












      4








      4





      $begingroup$


      #include <stdio.h>
      #include <stdlib.h>
      #include <string.h>
      #include <stdbool.h>

      typedef int STATUS;
      #define ERROR -1
      #define OKAY 0

      struct version

      unsigned char major;
      unsigned char minor;
      unsigned char build;
      unsigned char patch;
      ;
      STATUS is_less_than(struct version * original, struct version *compared, bool *result)



      Is there a cleaner way to do this?










      share|improve this question









      $endgroup$




      #include <stdio.h>
      #include <stdlib.h>
      #include <string.h>
      #include <stdbool.h>

      typedef int STATUS;
      #define ERROR -1
      #define OKAY 0

      struct version

      unsigned char major;
      unsigned char minor;
      unsigned char build;
      unsigned char patch;
      ;
      STATUS is_less_than(struct version * original, struct version *compared, bool *result)



      Is there a cleaner way to do this?







      c






      share|improve this question













      share|improve this question











      share|improve this question




      share|improve this question










      asked 5 hours ago









      the_endianthe_endian

      406312




      406312




















          3 Answers
          3






          active

          oldest

          votes


















          4












          $begingroup$

          Yes, there is a cleaner way:



          if (a.major != b.major) 
          *result = a.major < b.major;
          else if (a.minor != b.minor)
          *result = a.minor < b.minor;
          else if (a.patch != b.patch)
          *result = a.patch < b.patch;
          else
          *result = a.build < b.build;

          return OKAY;


          I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



          Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






          share|improve this answer











          $endgroup$












          • $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            2 hours ago


















          1












          $begingroup$

          I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



          The danger is further complicated by the fact that neither of the in-parameters is declared const.



          Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



          With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



          bool is_less_than(struct version a, struct version b) 
          return a.major != b.major ? a.major < b.major :
          a.minor != b.minor ? a.minor < b.minor :
          a.patch != b.patch ? a.patch < b.patch :
          a.build < b.build;



          I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






          share|improve this answer









          $endgroup$




















            0












            $begingroup$

            Return status



            You create this:



            typedef int STATUS;
            #define ERROR -1
            #define OKAY 0


            which is basically a boolean status. Personally, I'd return a straight bool.



            Bug/Not what you mean



            Doing a



            result = NULL;


            is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



            Shorter version



            I'm not sure this is cleaner, but here I go:



            bool is_less_than(struct version * original, struct version *compared, bool *result)
            original->major == compared->major && (
            original->minor < compared->minor


            Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



            int main(void) 

            struct version ref = 1, 2, 21, 8 ;
            struct version lower1 = 0, 2, 21, 8 ;
            struct version lower2 = 1, 1, 21, 8 ;
            struct version lower3 = 1, 2, 20, 8 ;
            struct version lower4 = 1, 2, 21, 7 ;
            struct version equal = 1, 2, 21, 8 ;
            struct version higher1 = 2, 2, 21, 8 ;
            struct version higher2 = 1, 3, 21, 8 ;
            struct version higher3 = 1, 2, 22, 8 ;
            struct version higher4 = 1, 2, 21, 9 ;

            #define TEST(a,b,expect1,expect2)
            do
            bool result1, result2;
            is_less_than((a), (b), &result1);
            is_less_than((b), (a), &result2);
            puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
            while(0)
            #define TESTL(a,b) TEST(a,b,true,false)
            #define TESTE(a,b) TEST(a,b,false,false)
            #define TESTH(a,b) TEST(a,b,false,true)

            TESTL(&lower1, &ref);
            TESTL(&lower2, &ref);
            TESTL(&lower3, &ref);
            TESTL(&lower4, &ref);
            TESTE(&equal, &ref);
            TESTH(&higher1, &ref);
            TESTH(&higher2, &ref);
            TESTH(&higher3, &ref);
            TESTH(&higher4, &ref);

            return 0;






            share|improve this answer











            $endgroup$








            • 1




              $begingroup$
              As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
              $endgroup$
              – Roland Illig
              1 hour ago











            • $begingroup$
              @RolandIllig Updated. Thank you for the suggestion.
              $endgroup$
              – Costantino Grana
              1 hour ago











            Your Answer






            StackExchange.ifUsing("editor", function ()
            StackExchange.using("externalEditor", function ()
            StackExchange.using("snippets", function ()
            StackExchange.snippets.init();
            );
            );
            , "code-snippets");

            StackExchange.ready(function()
            var channelOptions =
            tags: "".split(" "),
            id: "196"
            ;
            initTagRenderer("".split(" "), "".split(" "), channelOptions);

            StackExchange.using("externalEditor", function()
            // Have to fire editor after snippets, if snippets enabled
            if (StackExchange.settings.snippets.snippetsEnabled)
            StackExchange.using("snippets", function()
            createEditor();
            );

            else
            createEditor();

            );

            function createEditor()
            StackExchange.prepareEditor(
            heartbeatType: 'answer',
            autoActivateHeartbeat: false,
            convertImagesToLinks: false,
            noModals: true,
            showLowRepImageUploadWarning: true,
            reputationToPostImages: null,
            bindNavPrevention: true,
            postfix: "",
            imageUploader:
            brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
            contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
            allowUrls: true
            ,
            onDemand: true,
            discardSelector: ".discard-answer"
            ,immediatelyShowMarkdownHelp:true
            );



            );













            draft saved

            draft discarded


















            StackExchange.ready(
            function ()
            StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217587%2fcompare-a-given-version-number-in-the-form-major-minor-build-patch-and-see-if-on%23new-answer', 'question_page');

            );

            Post as a guest















            Required, but never shown

























            3 Answers
            3






            active

            oldest

            votes








            3 Answers
            3






            active

            oldest

            votes









            active

            oldest

            votes






            active

            oldest

            votes









            4












            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$












            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago















            4












            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$












            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago













            4












            4








            4





            $begingroup$

            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.






            share|improve this answer











            $endgroup$



            Yes, there is a cleaner way:



            if (a.major != b.major) 
            *result = a.major < b.major;
            else if (a.minor != b.minor)
            *result = a.minor < b.minor;
            else if (a.patch != b.patch)
            *result = a.patch < b.patch;
            else
            *result = a.build < b.build;

            return OKAY;


            I reordered patch to come before build since that's how it is usually done. If your version scheme is different from this, good luck.



            Instead of unsigned char I would choose unsigned int so that your code can handle versions like 1.0.20190415.







            share|improve this answer














            share|improve this answer



            share|improve this answer








            edited 1 hour ago

























            answered 2 hours ago









            Roland IlligRoland Illig

            11.6k11946




            11.6k11946











            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago
















            • $begingroup$
              Nice catch on the patch, build ordering.
              $endgroup$
              – Costantino Grana
              2 hours ago















            $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            2 hours ago




            $begingroup$
            Nice catch on the patch, build ordering.
            $endgroup$
            – Costantino Grana
            2 hours ago













            1












            $begingroup$

            I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



            The danger is further complicated by the fact that neither of the in-parameters is declared const.



            Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



            With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



            bool is_less_than(struct version a, struct version b) 
            return a.major != b.major ? a.major < b.major :
            a.minor != b.minor ? a.minor < b.minor :
            a.patch != b.patch ? a.patch < b.patch :
            a.build < b.build;



            I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






            share|improve this answer









            $endgroup$

















              1












              $begingroup$

              I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



              The danger is further complicated by the fact that neither of the in-parameters is declared const.



              Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



              With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



              bool is_less_than(struct version a, struct version b) 
              return a.major != b.major ? a.major < b.major :
              a.minor != b.minor ? a.minor < b.minor :
              a.patch != b.patch ? a.patch < b.patch :
              a.build < b.build;



              I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






              share|improve this answer









              $endgroup$















                1












                1








                1





                $begingroup$

                I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



                The danger is further complicated by the fact that neither of the in-parameters is declared const.



                Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



                With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



                bool is_less_than(struct version a, struct version b) 
                return a.major != b.major ? a.major < b.major :
                a.minor != b.minor ? a.minor < b.minor :
                a.patch != b.patch ? a.patch < b.patch :
                a.build < b.build;



                I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.






                share|improve this answer









                $endgroup$



                I don't see any advantage to having the function to take three pointers (two for input and one for output) and return a status code. As a result of that unnecessarily error-prone design, the function has to handle the possibility of null pointers, and the caller is expected to handle a status code. But why should such a simple comparison have these failure modes at all?



                The danger is further complicated by the fact that neither of the in-parameters is declared const.



                Just pass the two versions by value, and you would eliminate all of that complication! On any modern 32-bit or 64-bit processor, passing a four-byte struct by value should actually be more efficient than passing it by reference — especially since you don't have to dereference the pointers to access each field.



                With all of the potential errors out of the way, taking @RolandIllig's suggestion, you could then reduce it down to one chained conditional expression:



                bool is_less_than(struct version a, struct version b) 
                return a.major != b.major ? a.major < b.major :
                a.minor != b.minor ? a.minor < b.minor :
                a.patch != b.patch ? a.patch < b.patch :
                a.build < b.build;



                I'd go further and recommend using unsigned short instead of unsigned char for the fields. Using unsigned char for numeric values is awkward, since you would have to cast them when using printf(). On a 64-bit architecture, a struct with four 2-byte fields would occupy 64 bits, so you wouldn't be saving anything by using unsigned char instead of unsigned short.







                share|improve this answer












                share|improve this answer



                share|improve this answer










                answered 56 mins ago









                200_success200_success

                131k17157422




                131k17157422





















                    0












                    $begingroup$

                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    original->major == compared->major && (
                    original->minor < compared->minor


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;






                    share|improve this answer











                    $endgroup$








                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      1 hour ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago















                    0












                    $begingroup$

                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    original->major == compared->major && (
                    original->minor < compared->minor


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;






                    share|improve this answer











                    $endgroup$








                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      1 hour ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago













                    0












                    0








                    0





                    $begingroup$

                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    original->major == compared->major && (
                    original->minor < compared->minor


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;






                    share|improve this answer











                    $endgroup$



                    Return status



                    You create this:



                    typedef int STATUS;
                    #define ERROR -1
                    #define OKAY 0


                    which is basically a boolean status. Personally, I'd return a straight bool.



                    Bug/Not what you mean



                    Doing a



                    result = NULL;


                    is changing the local variable (parameter) result. It's not setting the result to NULL. In fact the caller won't probably have a pointer at all, but just a bool, which cannot properly be NULL.



                    Shorter version



                    I'm not sure this is cleaner, but here I go:



                    bool is_less_than(struct version * original, struct version *compared, bool *result)
                    original->major == compared->major && (
                    original->minor < compared->minor


                    Next time, add a driver/test suite to your question, to ease the life of people answering. This can be one:



                    int main(void) 

                    struct version ref = 1, 2, 21, 8 ;
                    struct version lower1 = 0, 2, 21, 8 ;
                    struct version lower2 = 1, 1, 21, 8 ;
                    struct version lower3 = 1, 2, 20, 8 ;
                    struct version lower4 = 1, 2, 21, 7 ;
                    struct version equal = 1, 2, 21, 8 ;
                    struct version higher1 = 2, 2, 21, 8 ;
                    struct version higher2 = 1, 3, 21, 8 ;
                    struct version higher3 = 1, 2, 22, 8 ;
                    struct version higher4 = 1, 2, 21, 9 ;

                    #define TEST(a,b,expect1,expect2)
                    do
                    bool result1, result2;
                    is_less_than((a), (b), &result1);
                    is_less_than((b), (a), &result2);
                    puts(result1==(expect1) && result2==(expect2)?"ok":"failed");
                    while(0)
                    #define TESTL(a,b) TEST(a,b,true,false)
                    #define TESTE(a,b) TEST(a,b,false,false)
                    #define TESTH(a,b) TEST(a,b,false,true)

                    TESTL(&lower1, &ref);
                    TESTL(&lower2, &ref);
                    TESTL(&lower3, &ref);
                    TESTL(&lower4, &ref);
                    TESTE(&equal, &ref);
                    TESTH(&higher1, &ref);
                    TESTH(&higher2, &ref);
                    TESTH(&higher3, &ref);
                    TESTH(&higher4, &ref);

                    return 0;







                    share|improve this answer














                    share|improve this answer



                    share|improve this answer








                    edited 1 hour ago

























                    answered 2 hours ago









                    Costantino GranaCostantino Grana

                    18728




                    18728







                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      1 hour ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago












                    • 1




                      $begingroup$
                      As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                      $endgroup$
                      – Roland Illig
                      1 hour ago











                    • $begingroup$
                      @RolandIllig Updated. Thank you for the suggestion.
                      $endgroup$
                      – Costantino Grana
                      1 hour ago







                    1




                    1




                    $begingroup$
                    As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                    $endgroup$
                    – Roland Illig
                    1 hour ago





                    $begingroup$
                    As for every comparator function, the driver/test should compare each pair of example data to at least ensure that the ordering is transitive and that less(x, x) is never true.
                    $endgroup$
                    – Roland Illig
                    1 hour ago













                    $begingroup$
                    @RolandIllig Updated. Thank you for the suggestion.
                    $endgroup$
                    – Costantino Grana
                    1 hour ago




                    $begingroup$
                    @RolandIllig Updated. Thank you for the suggestion.
                    $endgroup$
                    – Costantino Grana
                    1 hour ago

















                    draft saved

                    draft discarded
















































                    Thanks for contributing an answer to Code Review Stack Exchange!


                    • Please be sure to answer the question. Provide details and share your research!

                    But avoid


                    • Asking for help, clarification, or responding to other answers.

                    • Making statements based on opinion; back them up with references or personal experience.

                    Use MathJax to format equations. MathJax reference.


                    To learn more, see our tips on writing great answers.




                    draft saved


                    draft discarded














                    StackExchange.ready(
                    function ()
                    StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f217587%2fcompare-a-given-version-number-in-the-form-major-minor-build-patch-and-see-if-on%23new-answer', 'question_page');

                    );

                    Post as a guest















                    Required, but never shown





















































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown

































                    Required, but never shown














                    Required, but never shown












                    Required, but never shown







                    Required, but never shown







                    Popular posts from this blog

                    19. јануар Садржај Догађаји Рођења Смрти Празници и дани сећања Види још Референце Мени за навигацијуу

                    Israel Cuprins Etimologie | Istorie | Geografie | Politică | Demografie | Educație | Economie | Cultură | Note explicative | Note bibliografice | Bibliografie | Legături externe | Meniu de navigaresite web oficialfacebooktweeterGoogle+Instagramcanal YouTubeInstagramtextmodificaremodificarewww.technion.ac.ilnew.huji.ac.ilwww.weizmann.ac.ilwww1.biu.ac.ilenglish.tau.ac.ilwww.haifa.ac.ilin.bgu.ac.ilwww.openu.ac.ilwww.ariel.ac.ilCIA FactbookHarta Israelului"Negotiating Jerusalem," Palestine–Israel JournalThe Schizoid Nature of Modern Hebrew: A Slavic Language in Search of a Semitic Past„Arabic in Israel: an official language and a cultural bridge”„Latest Population Statistics for Israel”„Israel Population”„Tables”„Report for Selected Countries and Subjects”Human Development Report 2016: Human Development for Everyone„Distribution of family income - Gini index”The World FactbookJerusalem Law„Israel”„Israel”„Zionist Leaders: David Ben-Gurion 1886–1973”„The status of Jerusalem”„Analysis: Kadima's big plans”„Israel's Hard-Learned Lessons”„The Legacy of Undefined Borders, Tel Aviv Notes No. 40, 5 iunie 2002”„Israel Journal: A Land Without Borders”„Population”„Israel closes decade with population of 7.5 million”Time Series-DataBank„Selected Statistics on Jerusalem Day 2007 (Hebrew)”Golan belongs to Syria, Druze protestGlobal Survey 2006: Middle East Progress Amid Global Gains in FreedomWHO: Life expectancy in Israel among highest in the worldInternational Monetary Fund, World Economic Outlook Database, April 2011: Nominal GDP list of countries. Data for the year 2010.„Israel's accession to the OECD”Popular Opinion„On the Move”Hosea 12:5„Walking the Bible Timeline”„Palestine: History”„Return to Zion”An invention called 'the Jewish people' – Haaretz – Israel NewsoriginalJewish and Non-Jewish Population of Palestine-Israel (1517–2004)ImmigrationJewishvirtuallibrary.orgChapter One: The Heralders of Zionism„The birth of modern Israel: A scrap of paper that changed history”„League of Nations: The Mandate for Palestine, 24 iulie 1922”The Population of Palestine Prior to 1948originalBackground Paper No. 47 (ST/DPI/SER.A/47)History: Foreign DominationTwo Hundred and Seventh Plenary Meeting„Israel (Labor Zionism)”Population, by Religion and Population GroupThe Suez CrisisAdolf EichmannJustice Ministry Reply to Amnesty International Report„The Interregnum”Israel Ministry of Foreign Affairs – The Palestinian National Covenant- July 1968Research on terrorism: trends, achievements & failuresThe Routledge Atlas of the Arab–Israeli conflict: The Complete History of the Struggle and the Efforts to Resolve It"George Habash, Palestinian Terrorism Tactician, Dies at 82."„1973: Arab states attack Israeli forces”Agranat Commission„Has Israel Annexed East Jerusalem?”original„After 4 Years, Intifada Still Smolders”From the End of the Cold War to 2001originalThe Oslo Accords, 1993Israel-PLO Recognition – Exchange of Letters between PM Rabin and Chairman Arafat – Sept 9- 1993Foundation for Middle East PeaceSources of Population Growth: Total Israeli Population and Settler Population, 1991–2003original„Israel marks Rabin assassination”The Wye River Memorandumoriginal„West Bank barrier route disputed, Israeli missile kills 2”"Permanent Ceasefire to Be Based on Creation Of Buffer Zone Free of Armed Personnel Other than UN, Lebanese Forces"„Hezbollah kills 8 soldiers, kidnaps two in offensive on northern border”„Olmert confirms peace talks with Syria”„Battleground Gaza: Israeli ground forces invade the strip”„IDF begins Gaza troop withdrawal, hours after ending 3-week offensive”„THE LAND: Geography and Climate”„Area of districts, sub-districts, natural regions and lakes”„Israel - Geography”„Makhteshim Country”Israel and the Palestinian Territories„Makhtesh Ramon”„The Living Dead Sea”„Temperatures reach record high in Pakistan”„Climate Extremes In Israel”Israel in figures„Deuteronom”„JNF: 240 million trees planted since 1901”„Vegetation of Israel and Neighboring Countries”Environmental Law in Israel„Executive branch”„Israel's election process explained”„The Electoral System in Israel”„Constitution for Israel”„All 120 incoming Knesset members”„Statul ISRAEL”„The Judiciary: The Court System”„Israel's high court unique in region”„Israel and the International Criminal Court: A Legal Battlefield”„Localities and population, by population group, district, sub-district and natural region”„Israel: Districts, Major Cities, Urban Localities & Metropolitan Areas”„Israel-Egypt Relations: Background & Overview of Peace Treaty”„Solana to Haaretz: New Rules of War Needed for Age of Terror”„Israel's Announcement Regarding Settlements”„United Nations Security Council Resolution 497”„Security Council resolution 478 (1980) on the status of Jerusalem”„Arabs will ask U.N. to seek razing of Israeli wall”„Olmert: Willing to trade land for peace”„Mapping Peace between Syria and Israel”„Egypt: Israel must accept the land-for-peace formula”„Israel: Age structure from 2005 to 2015”„Global, regional, and national disability-adjusted life years (DALYs) for 306 diseases and injuries and healthy life expectancy (HALE) for 188 countries, 1990–2013: quantifying the epidemiological transition”10.1016/S0140-6736(15)61340-X„World Health Statistics 2014”„Life expectancy for Israeli men world's 4th highest”„Family Structure and Well-Being Across Israel's Diverse Population”„Fertility among Jewish and Muslim Women in Israel, by Level of Religiosity, 1979-2009”„Israel leaders in birth rate, but poverty major challenge”„Ethnic Groups”„Israel's population: Over 8.5 million”„Israel - Ethnic groups”„Jews, by country of origin and age”„Minority Communities in Israel: Background & Overview”„Israel”„Language in Israel”„Selected Data from the 2011 Social Survey on Mastery of the Hebrew Language and Usage of Languages”„Religions”„5 facts about Israeli Druze, a unique religious and ethnic group”„Israël”Israel Country Study Guide„Haredi city in Negev – blessing or curse?”„New town Harish harbors hopes of being more than another Pleasantville”„List of localities, in alphabetical order”„Muncitorii români, doriți în Israel”„Prietenia româno-israeliană la nevoie se cunoaște”„The Higher Education System in Israel”„Middle East”„Academic Ranking of World Universities 2016”„Israel”„Israel”„Jewish Nobel Prize Winners”„All Nobel Prizes in Literature”„All Nobel Peace Prizes”„All Prizes in Economic Sciences”„All Nobel Prizes in Chemistry”„List of Fields Medallists”„Sakharov Prize”„Țara care și-a sfidat "destinul" și se bate umăr la umăr cu Silicon Valley”„Apple's R&D center in Israel grew to about 800 employees”„Tim Cook: Apple's Herzliya R&D center second-largest in world”„Lecții de economie de la Israel”„Land use”Israel Investment and Business GuideA Country Study: IsraelCentral Bureau of StatisticsFlorin Diaconu, „Kadima: Flexibilitate și pragmatism, dar nici un compromis în chestiuni vitale", în Revista Institutului Diplomatic Român, anul I, numărul I, semestrul I, 2006, pp. 71-72Florin Diaconu, „Likud: Dreapta israeliană constant opusă retrocedării teritoriilor cureite prin luptă în 1967", în Revista Institutului Diplomatic Român, anul I, numărul I, semestrul I, 2006, pp. 73-74MassadaIsraelul a crescut in 50 de ani cât alte state intr-un mileniuIsrael Government PortalIsraelIsraelIsraelmmmmmXX451232cb118646298(data)4027808-634110000 0004 0372 0767n7900328503691455-bb46-37e3-91d2-cb064a35ffcc1003570400564274ge1294033523775214929302638955X146498911146498911

                    Smell Mother Skizze Discussion Tachometer Jar Alligator Star 끌다 자세 의문 과학적t Barbaric The round system critiques the connection. Definition: A wind instrument of music in use among the Spaniards Nasty Level 이상 분노 금년 월급 근교 Cloth Owner Permissible Shock Purring Parched Raise 오전 장면 햄 서투르다 The smash instructs the squeamish instrument. Large Nosy Nalpure Chalk Travel Crayon Bite your tongue The Hulk 신호 대사 사과하다 The work boosts the knowledgeable size. Steeplump Level Wooden Shake Teaching Jump 이제 복도 접다 공중전화 부지런하다 Rub Average Ruthless Busyglide Glost oven Didelphia Control A fly on the wall Jaws 지하철 거